Add exactSelector option to match only provided selector#280
Open
lynlevenick wants to merge 2 commits intobezoerb:mainfrom
Open
Add exactSelector option to match only provided selector#280lynlevenick wants to merge 2 commits intobezoerb:mainfrom
lynlevenick wants to merge 2 commits intobezoerb:mainfrom
Conversation
The selector option provides only one of four selectors, so if another matches then the option is ignored. Add a new option which controls whether the provided selector is the only one used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selector option provides only one of four selectors, so if another matches before the user's selector then the option is ignored. Add a new option which controls whether the provided selector is the only one used.
For my use case, this would fix a potential rerender where the stylesheet is added before an inlined script in head. On occasion, the browser renders the page background, which can result in a full-screen white background flash when dark mode is desired by the user.
edit: I'm not sure why the Node 10 tests are failing; something to do with coverage?
At present, I'm hacking around this with something like so:
so no worries if this is out of scope.